fix: Ensure request.url is with correct protocol in route handlers #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 148d057 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
Sep 2, 2025
vicb
reviewed
Sep 2, 2025
vicb
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Thanks a lot @sommeeeer for fixing this long standing issue.
I have added a couple of minor comments inline. The PR is good to go when those are addressed.
Edit: and kudos for the PR description too. Adding context is super helpful to ease the review 🙏
Co-authored-by: Victor Berchet <[email protected]>
|
Thanks for the review Victor! |
sommeeeer
changed the title
sommeeeer
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for opennextjs/opennextjs-aws#969
We patch NextServer's
attachRequestMetaas it will be called inhandleRequestImpl.In theory we can also just comment out that line as we pass ininitURLtonextServer.getRequestHandlerWithMetadataarguments already here when we process the request through NextServer.Has been tested on Next 14 aswell.
I did update the tests that relied on this aswell.
Update: Turns out in pages router it relies on
initURLto be this template string value. Reason is that it wont have the_next/datapart in theinitURLwe passed in to the request handlers metadata, however it will be inreq.url. Because of that I just updated the fix to only replace the protocol instead.